[vcpkg_check_linkage] Clarify ONLY_DYNAMIC_LIBRARY failures and supports expressions. #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BillyONeal : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 5175974: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
Thomas1664
reviewed
Dec 9, 2024
| @@ -38,7 +41,33 @@ Indicates that this port can only be built with dynamic/shared CRT linkage. | |||
|
|
|||
| ## Notes | |||
|
|
|||
| This command will either alter the settings for `VCPKG_LIBRARY_LINKAGE` or fail, depending on what was requested by the user versus what the library supports. | |||
| If the triplet requests a setting of `VCPKG_LIBRARY_LINAKGE` different than the port supports, | |||
| and changing `VCPKG_LIBRARY_LINKAGE` to that the port supports is cosidered safe, | |||
There was a problem hiding this comment.
Suggested change
| and changing `VCPKG_LIBRARY_LINKAGE` to that the port supports is cosidered safe, | |
| and changing `VCPKG_LIBRARY_LINKAGE` to that the port supports is considered safe, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: microsoft/vcpkg#42508